From 697a4bfcd0ed8634feeb9f7345d96e5030dae856 Mon Sep 17 00:00:00 2001 From: Gardouille Date: Mon, 1 Jun 2015 11:56:08 +0200 Subject: [PATCH] * Correct puppet-lint warnings. --- CHANGELOG.md | 1 + manifests/hypervisor/cluster.pp | 1 + manifests/hypervisor/config.pp | 1 + manifests/hypervisor/install.pp | 5 +++-- 4 files changed, 6 insertions(+), 2 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index d66f4bb..59742d5 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -10,6 +10,7 @@ * Some installation's instructions only run if running a PVE kernel (test the new is_pve_kernel fact). * Use the stdlib function 'ensure_packages' to install recommended packages instead of 'if ! defined'. * Upgrade pve-kernel-3.10.0-9-pve and pve-kernel-2.6.32-39 to the last version. +* Correct puppet-lint warnings. ##### Bugfixes * #14 The module no longer automatically reboot nodes after kernel upgrade, show a warning message instead. diff --git a/manifests/hypervisor/cluster.pp b/manifests/hypervisor/cluster.pp index f3ab3a4..61f27a4 100644 --- a/manifests/hypervisor/cluster.pp +++ b/manifests/hypervisor/cluster.pp @@ -16,6 +16,7 @@ class proxmox::hypervisor::cluster logoutput => 'on_failure', } + ## Quoted boolean value because can't return "true" boolean with personal fact if $::is_proxmox == 'true' and $proxmox::hypervisor::cluster_master_ip != undef and $proxmox::hypervisor::cluster_name != undef { # Ensure the root user got an ssh-key exec { 'create ssh-key for root': diff --git a/manifests/hypervisor/config.pp b/manifests/hypervisor/config.pp index fa4890f..6046ace 100644 --- a/manifests/hypervisor/config.pp +++ b/manifests/hypervisor/config.pp @@ -16,6 +16,7 @@ class proxmox::hypervisor::config { } + ## Quoted boolean value because can't return "true" boolean with personal fact if $::is_proxmox == 'true' { # Pveproxy access control list diff --git a/manifests/hypervisor/install.pp b/manifests/hypervisor/install.pp index fd47eb9..89e2bbe 100644 --- a/manifests/hypervisor/install.pp +++ b/manifests/hypervisor/install.pp @@ -10,6 +10,7 @@ class proxmox::hypervisor::install { } # If the system already run a PVE kernel + ## Quoted boolean value because can't return "true" boolean with personal fact if $::is_pve_kernel == 'true' { # Installation of Virtual Environnment @@ -35,7 +36,7 @@ class proxmox::hypervisor::install { # Installation of the PVE Kernel if $proxmox::hypervisor::kvm_only == true { - notify { "Please REBOOT": + notify { 'Please REBOOT': message => "Need to REBOOT the system on the new PVE kernel (${proxmox::hypervisor::kernel_kvm_pkg_name}) ...", loglevel => warning, } @@ -46,7 +47,7 @@ class proxmox::hypervisor::install { } } else { - notify { "Please REBOOT": + notify { 'Please REBOOT': message => "Need to REBOOT the system on the new PVE kernel (${proxmox::hypervisor::kernel_pkg_name}) ...", loglevel => warning, }