* Correct some warnings from Puppet-lint.

This commit is contained in:
gardouille 2015-02-09 11:59:29 +01:00
parent 0804239bcc
commit 3a84f98393
4 changed files with 12 additions and 6 deletions

View File

@ -1,6 +1,13 @@
---------------------------------------
###
##### Changes
* Correct some warnings from Puppet-lint.
---------------------------------------
### 0.1.2 - 2015/02/09
Minor release but it correct the possibility to disable a channel :)

View File

@ -24,9 +24,9 @@ class ipmi::config {
}
}
# Additionnal modules to load at boot time
file { "${ipmi::modules_file_path}":
file { $ipmi::modules_file_path:
ensure => 'present',
content => template("${ipmi::modules_file_content}"),
content => template($ipmi::modules_file_content),
require => File['/etc/modules-load.d'],
notify => Exec["load_${ipmi::needed_module_name}_module"],
}

View File

@ -4,9 +4,8 @@
#
class ipmi::install {
# Don't use "${ipmi::pkg_name:}" because pkg_name variable is an array
package { $ipmi::pkg_name:
ensure => "${ipmi::pkg_ensure}",
ensure => $ipmi::pkg_ensure,
}
} # Private class: ipmi::install

View File

@ -45,8 +45,8 @@ define ipmi::ressource::channel ( $channel_id = $title, $ipaddr = '0.0.0.0', $ne
->
# Enable remote access
exec { "IPMI set remote access to ${remote_access} for channel ${channel_id}":
command => "ipmitool -I open lan set ${channel_id} access ${remote_access}",
onlyif => $remote_access ? {
command => "ipmitool -I open lan set ${channel_id} access ${remote_access}",
onlyif => $remote_access ? {
'off' => "ipmitool -I open channel info ${channel_id} | grep -i 'Access Mode .* available'",
default => "ipmitool -I open channel info ${channel_id} | grep -i 'Access Mode .* disable'",
},